Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto detect language on first start #78

Merged
merged 1 commit into from
Jan 5, 2019
Merged

auto detect language on first start #78

merged 1 commit into from
Jan 5, 2019

Conversation

whyboris
Copy link
Owner

@whyboris whyboris commented Jan 5, 2019

Should detect the language correctly on first start.

After that, the language will be set to the last-used language in the app 👌

Closes #26

@whyboris whyboris added the ✏️ ready for review PR is ready for review label Jan 5, 2019
@whyboris whyboris requested a review from cal2195 January 5, 2019 04:40
@whyboris whyboris mentioned this pull request Jan 5, 2019
Closed
cal2195
cal2195 approved these changes Jan 5, 2019
View reviewed changes
Copy link
Collaborator

@cal2195 cal2195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@cal2195 cal2195 merged commit b51d7d2 into master Jan 5, 2019
@cal2195 cal2195 deleted the locale branch January 5, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cal2195 cal2195 cal2195 approved these changes

Assignees
No one assigned
Labels
✏️ ready for review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whyboris @cal2195