Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boris - what I'm working on #99

Closed
4 tasks done
whyboris opened this issue Jan 10, 2019 · 13 comments · Fixed by #140
Closed
4 tasks done

Boris - what I'm working on #99

whyboris opened this issue Jan 10, 2019 · 13 comments · Fixed by #140
Assignees
Labels
discussion Thoughts and ideas

Comments

@whyboris
Copy link
Owner

whyboris commented Jan 10, 2019

This is a small experiment to see if it's useful to have a public-facing "what I'm working on" on this list.

This is a place to be more transparent about what tasks I'm thinking of working on next. It's also a discussion - so please let me know if something should be a higher priority. I'm also happy to let anyone take over any task if it's of interest to them 🙇

My aim is to always do all the code review before starting / resuming on my own coding.

Currently on my todo list in priority order (more will be added as I complete these):

@whyboris whyboris added the discussion Thoughts and ideas label Jan 10, 2019
@cal2195
Copy link
Collaborator

cal2195 commented Jan 11, 2019

I've just made a project (https://github.com/whyboris/Video-Hub-App/projects/1) for this purpose! It seems to fit pretty well for this idea - which method do you prefer? 💡

@whyboris
Copy link
Owner Author

whyboris commented Jan 11, 2019

I'll keep both for some time and we'll see together which we like best 👍

Even if an issue tracker / project board adds an extra step we need to do, there's some psychological satisfaction (at least I get) to putting check marks on checkboxes, or moving items along a Trello-like board 😅

@cal2195
Copy link
Collaborator

cal2195 commented Jan 11, 2019

Haha, I know what you mean! 😂

  • Reply to Boris.

@whyboris
Copy link
Owner Author

whyboris commented Jan 15, 2019

Small additions:

  • Add width and height fields to ImageElement, removing the hardcoded ResolutionString - meanwhile, also insert a temporary field for resolution (so as to compute it once: on-file-open, not every time: on-view). Also insert temporary field for resolution category (so the resolution filter service isn't crunching through switch/case every time.
  • Make the ⭐️ ⭐️ ⭐️ freshly-added star rating remain after scrolling away and scrolling back; Confirm that scrolling away and coming back doesn't remove the newly-added tags (reconcile if/why behavior different)

@whyboris
Copy link
Owner Author

whyboris commented Jan 15, 2019

Another good task I'll take care of:

  • consider passing in the ImageElement rather than individual pieces of information into each component in the gallery

@whyboris whyboris self-assigned this Jan 19, 2019
@whyboris
Copy link
Owner Author

This PR addresses many of the above tasks on my todo list 👍 #108

@whyboris whyboris mentioned this issue Jan 19, 2019
7 tasks
@whyboris
Copy link
Owner Author

whyboris commented Jan 19, 2019

Minor tasks from #86

  • Add Date Added field (when added to the hub), and/or
  • Add Date Created field (read file metadata)
  • Add Number of Times Played field
  • Add accompanying sorting options (and one for stars)

@whyboris
Copy link
Owner Author

I'm giving Projects a try: https://github.com/whyboris/Video-Hub-App/projects/2

@whyboris
Copy link
Owner Author

I like projects a lot to keep my to do list organized. I'll use that instead of this issue.

I'll close this issue as soon as I implement the number of times played and stars sorting options.

@whyboris whyboris moved this from To do backlog to To do next in Boris's Current Workflow Jan 29, 2019
@whyboris whyboris moved this from To do next to In progress in Boris's Current Workflow Feb 1, 2019
@whyboris whyboris moved this from In progress to In review in Boris's Current Workflow Feb 2, 2019
@theotherp
Copy link

I'm not sure if this is the correct place to comment but I can't find the option to sort by anything but duration and size. I too would love to sort by recently added and file modification date.

@whyboris
Copy link
Owner Author

It's not obvious where the settings for that are.
Please go to settings, click on the Search settings tab, and scroll to the bottom.
The next-to-last section, titled "Show or hide various sorting options in the dropdown" allows you to enable other sort options besides the default few.

ps -- I'm thinking of including 'sort alphabetical' option before version 2 release 🙌

@theotherp
Copy link

theotherp commented Aug 14, 2019 via email

@whyboris
Copy link
Owner Author

Thank you for the note -- I'll make sure to make features more visible (likely through a website Features section) :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Thoughts and ideas
Projects
Development

Successfully merging a pull request may close this issue.

3 participants