Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log_async in WhylabsWriter #359

Merged
merged 12 commits into from
Nov 30, 2021
Merged

Conversation

richard-rogers
Copy link
Contributor

Description

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

pyproject.toml Outdated Show resolved Hide resolved
src/whylogs/whylabs_client/wrapper.py Outdated Show resolved Hide resolved
@jamie256
Copy link
Contributor

Another minor thing, your commit message has a typo:
"whylabs writier" should be Whylabs writer or use the class name WhylabsWriter

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

pyproject.toml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 20, 2021

Pull Request Test Coverage Report for Build 1483377784

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 79.852%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/whylabs_client/wrapper.py 0 8 0.0%
Totals Coverage Status
Change from base Build 1477783271: -0.1%
Covered Lines: 3661
Relevant Lines: 4451

💛 - Coveralls

@richard-rogers richard-rogers changed the title Use log_async in whylabs writier Use log_async in WhylabsWriter Nov 22, 2021
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@jamie256 jamie256 added the performance Performance improvements label Nov 30, 2021
@richard-rogers richard-rogers merged commit 85a35bc into mainline Nov 30, 2021
@richard-rogers richard-rogers deleted the dev/richard/log_async branch November 30, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants