Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraints example notebook typos fix #449

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Constraints example notebook typos fix #449

merged 3 commits into from
Feb 21, 2022

Conversation

pecop2
Copy link
Contributor

@pecop2 pecop2 commented Feb 21, 2022

Description

Fix some mistakes in the example notebook and append an example for the constraint created last, the missingValuesProportionBetweenConstraint

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@coveralls
Copy link

coveralls commented Feb 21, 2022 •
edited

Pull Request Test Coverage Report for Build 1878717349

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 82.512%
Files with Coverage Reduction New Missed Lines %
src/whylogs/core/summaryconverters.py 1 82.54%
Totals Coverage Status
Change from base Build 1878715988: 0%
Covered Lines: 4761
Relevant Lines: 5620
💛 - Coveralls

jamie256
jamie256 approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jamie256 jamie256 enabled auto-merge (squash) February 21, 2022 23:11
@jamie256 jamie256 merged commit 788b4be into mainline Feb 21, 2022
@jamie256 jamie256 deleted the dev/loka/constraint_examples_typos branch February 21, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie256 jamie256 jamie256 approved these changes

@MilenaTrajanoska MilenaTrajanoska Awaiting requested review from MilenaTrajanoska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pecop2 @coveralls @jamie256 @MilenaTrajanoska