Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile viewer fixes #486

Merged
merged 9 commits into from
Mar 23, 2022
Merged

Conversation

FelipeAdachi
Copy link
Contributor

Description

  • Constraints_report now shows every constraints for given feature instead of only the first one
  • Feature statistics now shows distinct values as percentage
  • Added warning for missing pybars 3 dependencies

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

src/whylogs/viz/browser_viz.py Outdated Show resolved Hide resolved
src/whylogs/viz/jupyter_notebook_viz.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 23, 2022

Pull Request Test Coverage Report for Build 2030428780

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 82.605%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/viz/browser_viz.py 0 1 0.0%
src/whylogs/viz/jupyter_notebook_viz.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/whylogs/viz/browser_viz.py 1 62.3%
Totals Coverage Status
Change from base Build 2030248078: 0.03%
Covered Lines: 4936
Relevant Lines: 5811

💛 - Coveralls

Copy link
Contributor

@jamie256 jamie256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamie256 jamie256 merged commit f2604f6 into whylabs:mainline Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants