Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile viewer fixes #486

Merged
merged 9 commits into from
Mar 23, 2022
Merged

Profile viewer fixes #486

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7be1746
Add NotebookProfileViewer notebook with wine quality dataset
FelipeAdachi Mar 17, 2022
866f26d
remove warnings
FelipeAdachi Mar 22, 2022
d207b21
Merge branch 'whylabs:mainline' into profile_viewer
FelipeAdachi Mar 23, 2022
0922f5f
- Constraints report now shows all constraints for given feature
FelipeAdachi Mar 23, 2022
787b669
remove notebook for wine drift
FelipeAdachi Mar 23, 2022
2e4c49f
Merge branch 'mainline' into profile_viewer_fixes
jamie256 Mar 23, 2022
f4acc1b
removed logger debug lines
FelipeAdachi Mar 23, 2022
ade95e8
Merge branch 'mainline' into profile_viewer_fixes
jamie256 Mar 23, 2022
187dc3a
Merge branch 'mainline' into profile_viewer_fixes
jamie256 Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/whylogs/viewer/templates/index-hbs-cdn-all-in-jupyter-constraints-report.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,10 +548,14 @@ <h1 class="no-responsive__title">Hold on! :)</h1>
return column.properties.tags.name
});


Handlebars.registerHelper("alertLIst", function (column) {
let alertListItem = column.map((value) => {
if (value[1][0]) {
return alertListElement(value[0], value[1][0][0], value[1][0][value[1][0].length - 1] === 0 || (failedConstraints++, false))
let alertListValue = value[1].map((cstr)=>{
return alertListElement(value[0],cstr[0],cstr[cstr.length - 1] === 0 || (failedConstraints++, false))
})
return alertListValue.join(' ')
} else {
return alertListElement('', value[0], value[value.length - 1] === 0 || (failedConstraints++, false))
}
Expand All @@ -563,6 +567,7 @@ <h1 class="no-responsive__title">Hold on! :)</h1>
})
return alertListItem.join(' ')
});

}

function openFilter() {
Expand Down
2 changes: 1 addition & 1 deletion src/whylogs/viewer/templates/index-hbs-cdn-all-in-jupyter-feature-summary-statistics.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ <h1 class="no-responsive__title">Hold on! :)</h1>
const feature = Object.values(column)[1]

if (feature.numberSummary && feature.numberSummary.uniqueCount) {
return feature.numberSummary.uniqueCount.estimate;
return (feature.numberSummary.uniqueCount.estimate/feature.numberSummary.count)*100;
}
return "0";
});
Expand Down
3 changes: 1 addition & 2 deletions src/whylogs/viz/browser_viz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ def profile_viewer(profiles: List[DatasetProfile] = None, reference_profiles: Li
except ImportError as e:
Compiler = None
logger.debug(str(e))
logger.debug("Unable to load pybars; install pybars3 to load profile from directly from the current session ")

logger.warning("Unable to load pybars; install pybars3 to load profile directly from the current session ")
index_path = os.path.abspath(os.path.join(_MY_DIR, os.pardir, "viewer/templates", "index.html"))
webbrowser.open_new_tab(f"file:{index_path}#")
return None
Expand Down
3 changes: 2 additions & 1 deletion src/whylogs/viz/jupyter_notebook_viz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ def __get_compiled_template(self, template_name):
except ImportError as e:
Compiler = None
logger.debug(str(e))
logger.debug("Unable to load pybars; install pybars3 to load profile from directly from the current session ")
logger.warning("Unable to load pybars; install pybars3 to load profile directly from the current session ")

with open(template_path, "r") as file_with_template:
source = file_with_template.read()
compiler = Compiler()
Expand Down