Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bumpversion to search and replace #510

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

TheMellyBee
Copy link
Contributor

Description

Problem:

Bump version workflow is broken #489 caused both the version number and a dependency version to be implement. This was due to the search and replace doing a simple search for just the numbers.

This caused one of the dependencies also on 0.7.0 to be matched and replaced.

Fix

bumpversion has a search and replace keywords that default to:

search={current_version}
replace={new_version}

Since we have several different file formats each of those needed to be specified

Future Maintenance needed

None

Testing

Manually tested it with the cause that failed (version 0.7.0). Please comment what tests you believe would be helpful on this.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • [na] Documentation updated
  • [X ] (optional) Please add a label to your PR

Helpful References

https://pypi.org/project/bumpversion/

@TheMellyBee TheMellyBee added the maintenance maintenance issues label Apr 4, 2022
@TheMellyBee TheMellyBee self-assigned this Apr 4, 2022
@coveralls
Copy link

coveralls commented Apr 5, 2022

Pull Request Test Coverage Report for Build 2093238025

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 82.615%

Files with Coverage Reduction New Missed Lines %
src/whylogs/core/summaryconverters.py 1 84.23%
Totals Coverage Status
Change from base Build 2093235697: -0.03%
Covered Lines: 4943
Relevant Lines: 5819

💛 - Coveralls

Copy link
Contributor

@richard-rogers richard-rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hit me once too

@jamie256 jamie256 merged commit 9c556f3 into mainline Apr 5, 2022
@jamie256 jamie256 deleted the bump-version-fix branch April 5, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance maintenance issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants