Add tests for warn_missing with revalue and mapvalues

wibeasley · Jan 3, 2014 · 4712104 · 4712104
1 parent d1858cd
commit 4712104
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -18,7 +18,7 @@ Depends:
     R (>= 2.11.0)
 Suggests:
     abind,
-    testthat (>= 0.2),
+    testthat (>= 0.7.1.99),
     tcltk,
     foreach,
     doMC,

diff --git a/inst/tests/test-revalue.r b/inst/tests/test-revalue.r
@@ -118,3 +118,20 @@ test_that("revalue and mapvalues accept empty vectors and NULL", {
   expect_identical(revalue(NULL, c("3"=30), warn_missing=FALSE), NULL)
   expect_identical(mapvalues(NULL, 3, 30, warn_missing=FALSE), NULL)
 })
+
+test_that("revalue and mapvalues respect warn_missing", {
+  # revalue
+  expect_that(revalue("a", c("a"="A")), not(shows_message()))
+  expect_that(revalue("a", c("b"="B"), warn_missing=TRUE), shows_message())
+  expect_that(revalue("a", c("b"="B"), warn_missing=FALSE), not(shows_message()))
+
+  # mapvalues
+  expect_that(mapvalues("a", "a", "A"), not(shows_message()))
+  expect_that(mapvalues("a", "b", "B", warn_missing=TRUE), shows_message())
+  expect_that(mapvalues("a", "b", "B", warn_missing=FALSE), not(shows_message()))
+
+  # mapvalues with factors
+  expect_that(mapvalues(factor("a"), "a", "A"), not(shows_message()))
+  expect_that(mapvalues(factor("a"), "b", "B", warn_missing=TRUE), shows_message())
+  expect_that(mapvalues(factor("a"), "b", "B", warn_missing=FALSE), not(shows_message()))
+})