Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for C++17 #1

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Fixes for C++17 #1

merged 2 commits into from
Jul 31, 2022

Conversation

robromano
Copy link
Contributor

std::ptr_fun was fully removed in 17, clang won't allow it. Use of lambdas is preferred. Should be compatible with C++11 but did not test.

@robromano robromano mentioned this pull request Jul 30, 2022
Closed
wichtounet
wichtounet reviewed Jul 30, 2022
View reviewed changes
Copy link
Owner

@wichtounet wichtounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed much better with a lambda. Could you just fix the type?

string.hpp Outdated Show resolved Hide resolved
string.hpp Outdated Show resolved Hide resolved
@wichtounet wichtounet merged commit 0ef0e4f into wichtounet:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wichtounet wichtounet wichtounet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robromano @wichtounet