Regressions with de/wm and theme

[IndrekHaav]

Some recent commit introduced an error under WSL2:

de/wm ~ de/wm ~ xprop:  unable to open display ''

Presumably the same can happen on other headless systems.

The label is also shown twice, because of line 47.

On a RPi4 running Ubuntu 20.04, xprop isn't found:

de/wm ~ de/wm ~ ./fetch.sh: line 48: xprop: command not found

Also, the "theme" label is indented, and under WSL2 also prints the path to gsettings:

 theme ~ /usr/bin/gsettings
'Adwaita'

Maybe instead of command -v gsettings, run which gsettings and test its return code?

[IndrekHaav]

Some of these might be duplicates of #16 and #17, sorry, didn't see those before posting this.

[wick3dr0se]

Can you run it again? I'm working on that right now and just made 3 commits. Post full output so I can see whats going on easier

[IndrekHaav]

Now under WSL2 getting this:

de/wm ~ /usr/bin/xprop
xprop:  unable to open display ''

Same suggestion as with gsettings - test with which instead of command?

[wick3dr0se]

It should work now. I accidentally left out the square brackets surrounding xprop and gsettings, if not I will attempt with which next

[wick3dr0se]

This should be fixed with -z $DISPLAY on commit 433c555. Please pull latest commit and test so we can get this issue closed!

[IndrekHaav]

On a RPi4 running Ubuntu 20.04, I get:

theme ~ ./components/de-wm_theme.sh: line 20: gsettings: command not found

In Debian 10 under WSL2, I get:

theme ~ No schemas installed

Not sure if this is a bug or intended.

Also, the "theme" row is still indented.

[wick3dr0se]

That should have fixed your issue with gsettings output. The issue is likely that you have no theme at all but the path shouldn't output at all because it's irrelevant info. No schemas installed likely prints from xprop and I would consider it a good output to keep, if that fails next it will echo not found. Theme row is hard indented on purpose, de/wm should output not found or your theme name and theme should be in same row indented to the side

[IndrekHaav]

I'll make a PR for the newline/indendation issue, seems like a really simple fix.

[wick3dr0se]

I'll close this as solved then! Thanks alot!

[GavinRay97]

Just as a random note + thank-you, your comment @IndrekHaav was the only Google result when searching for an error that broke my WSL2 distro after trying to do-release-upgrade.

If it wasn't for this issue pointing towards gsettings, I don't think I would have been able to fix it. So thank you 😃