Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE/WM/Theme detection on minimal installs. #17

Closed
wimb0 opened this issue Nov 22, 2021 · 9 comments
Closed

DE/WM/Theme detection on minimal installs. #17

wimb0 opened this issue Nov 22, 2021 · 9 comments

Comments

@wimb0
Copy link

wimb0 commented Nov 22, 2021

image

When running on my server, I get errors with DE/WM/Theme detection.
This is because there is no DE installed.
Maybe add logic to ignore these in the output when no DE is detected?

(Also, Max CPU speed is shown twice (and missing a space), and the sub GHz current speed misses the leading zero.)

@wick3dr0se
Copy link
Owner

I just made a couple commits that should fix your issues, can you check now?

@wimb0
Copy link
Author

wimb0 commented Nov 22, 2021

That was quick :-)
Seems to be solved!
image

No clue what 'Adwaita' is though...

@wick3dr0se
Copy link
Owner

Unfortunately Intel CPU's seem to include GHz. Not sure how to approach that just yet. I will keep this open as i'm working on closing the other issues. I'll probably just hide de/wm if not found, I need to remove the ' around theme name and hide 'Corporation' from gpu section

@wimb0
Copy link
Author

wimb0 commented Nov 22, 2021

For the GHz issue with Intel CPU's, maybe do something with if vendor_id = GenuineIntel in /proc/cpuinfo, do not add @1.23Ghz? (I'm not that good with shell scripts to fix that for you)

@wick3dr0se
Copy link
Owner

I pushed a new branch to intelcpu. Can you git clone -b intelcpu --single-branch https://github.com/wick3dr0se/fetch.sh and try this script? I dont want to push it to master until I know it works right

@wimb0
Copy link
Author

wimb0 commented Nov 22, 2021

Result of intelcpu.sh:
image

@wick3dr0se
Copy link
Owner

I approached it all wrong. Can you try it now?

@wimb0
Copy link
Author

wimb0 commented Nov 22, 2021

Done: result is now
image

@wick3dr0se
Copy link
Owner

wick3dr0se commented Nov 22, 2021

That's what I like to see!

I just pushed commit 0da184b for intel systems to cleanup gpu output and of course fix the duplicate cpu speed issue on the master branch. If any issue appears just open new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants