Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent insensitive search text #132

Open
dzapata14 opened this issue Sep 9, 2020 · 10 comments
Open

Accent insensitive search text #132

dzapata14 opened this issue Sep 9, 2020 · 10 comments

Comments

@dzapata14
Copy link

Hi everyone,

I write you because I don´t find any option to do accent insensitive search, Is possible to make an accent insensitive search?
If a do a search in a spanish text I get differents results if I type the word with accent and without accent.

Regards!!!

@wickedest
Copy link
Owner

@dzapata14, it works for me. Are you using this on mergely.com, or did you integrate it into your own application?

@dzapata14
Copy link
Author

Hi @wickedest, thanks for your help

I am using mergely in my own application. This is how I initialize:

$("#objeto").mergely({
width: 90,
height: 60,
cmsettings: {
mode: "text/html",
readOnly: true,
lineNumbers: true,
lineWrapping: true
},
sidebar: false
, ignorews: true
, ignorecase: true
, viewport: true
, sidebar: false
});

In the following link you can see the results.

mergely.docx

If I search the word constitución I got several results, but I search the word constitucion I only got one result.

I am using Mergely Version: 3.4.0

image

What do you think It is missing?

Regards!!!

@wickedest
Copy link
Owner

wickedest commented Sep 10, 2020 via email

@dzapata14
Copy link
Author

Hi @wickedest, thanks for your help

I am doing the test online but It doesn work, If i search the word constitucion only got results in lines 2 and 3, not match with line 1. What options allows me that match with line 1.

image

Regards!!!

@wickedest
Copy link
Owner

Ah, I completely misread what you were asking. I thought you were saying that it was accent insensitive. There's no way to enable that out of the box.

@dzapata14
Copy link
Author

Ok @wickedest, I appreciate your help, Do you think this functionality can be developed in the future?

@wickedest
Copy link
Owner

I doubt I'd get to it, not for a long time anyway. I labeled in enhancement and Hacktoberfest. Maybe someone's eager for a new T-shirt.

wickedest added a commit that referenced this issue Oct 15, 2020
* feat(#132): added  option to ignore accented characters

* fixed lf

Co-authored-by: Jamie Peabody <jpeabody@axway.com>
@wickedest
Copy link
Owner

Also added feature to https://editor.mergely.com

@dzapata14
Copy link
Author

Hi @wickedest, thanks for your help,

I am testing online but It doesnt work. I am searching the word constitucion and I activated the "ignored accented characters" but I got the words constitucion and constitucionalidad, but the word constitución is not int result.

image

image

Regards!!!!

@wickedest
Copy link
Owner

And again, I got it wrong. All of those "Ignore" options are for the diff, which confused me. Clearly, you want the "search" feature to be case insensitive. You were clear the whole time. Anyway, that's a problem - most of the search feature comes directly from CodeMirror search and searchcursor, and they don't seem to have that option. It'd be a good feature to add. I created a ticket there: codemirror/codemirror5#6448.

@wickedest wickedest reopened this Oct 23, 2020
@wickedest wickedest changed the title Accent insensitive Accent insensitive search text Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants