New functionality and some fixes for GMap3 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thyzzv
commented
Jan 31, 2013
thyzzv
commented
- Fixed Simple Ajax example
- Fixed parsing of large latlon coordinates
- Added option to use a Wicket component as content for a GInfoWindow.java (See AdvancedInfoWindowGMapApplication)
* Fixed parsing of large latlon coordinates * Added option to use a Wicket component as content for a GInfoWindow.java (See AdvancedInfoWindowGMapApplication)
| response.render(JavaScriptHeaderItem.forReference(WicketGMapJsReference.INSTANCE)); | ||
| response.render(JavaScriptHeaderItem.forUrl(String.format(GMAP_API_URL, schema, sensor))); |
There was a problem hiding this comment.
Is this reorder intentional ?
Now GMAP API js will be loaded after Wicket-Gmap. This may break with "gmap object undefined" or something similar.
There was a problem hiding this comment.
Yes it is intentional, I've been playing around with this for almost 2 weeks, and at some point this was the only thing that always worked. In all combinations with/without loading though wicket-ajax etc.
This is also why I changed wicket-gmap.js.
But I 'll give it another try.
martin-g
added a commit
that referenced
this pull request
Feb 2, 2013
New functionality and some fixes for GMap3
|
I'm going to release 6.5.0 so I've merged your changes. |
reckart
pushed a commit
to reckart/core
that referenced
this pull request
Mar 31, 2024
reckart
pushed a commit
to reckart/core
that referenced
this pull request
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.