-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to Wicket 10, Spring 6 and related Jakarta EE specs #741
Conversation
I will create branch |
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g the branch should be changed in https://github.com/wicketstuff/core/blob/wicket-9.x/.github/workflows/ci.yml |
Fixed it! Thanks! |
All tests are passing locally but GitHub Actions goes error
See https://github.com/wicketstuff/core/actions/runs/3847139651/jobs/6553240311#step:5:10121 |
This is a known issue. |
@martin-g now that build is green, I'd ask you to review this PR, especially for the changes due to Wicket upgrade. In particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
About the ModalWindow->ModalDialog changes - we can always fix them later if there are issues!
Thank you @martin-g ! |
It looks there is some issue with OSS SNAPSHOT deployment about credentials |
I'm uploading -SNAPSHOT from my machine... |
Ah, thank you |
Forgot to mention that the upload/deploy is done! |
great job @ilgrosso! |
@solomax my pleasure |
Following #740
Before merging this request to
master
branch, themaster
branch shall be copied as the newwicket-9.x
branch.Still draft because:
mvn clean install -DskipTests
works fine, but test results were not checked yetModalWindow
) are to be checked