Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds volunteer opportunities page, updates about and faq pages #215

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

arshiamufti
Copy link
Contributor

@arshiamufti arshiamufti commented Jun 5, 2016

addresses #102 and my bad for not making PR from feature branch :(

@ehashman ehashman temporarily deployed to wics-site-pr-215 June 6, 2016 00:01 Inactive
Title: Volunteer Opportunities
Category: pages
Summary: Volunteer opportunities available with WiCS undergraduate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to add a status: hidden metadata line here, otherwise we break the navbar which is a continuing issue we should probably fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really much to fix there. We can't change the default on that.

I believe that we do not want category or summary metadata here since those wouldn't ever get exposed anyways.

Copy link
Contributor Author

@arshiamufti arshiamufti Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does Category: pages do exactly? I only added because I saw other pages (mua.md, office-policy.md etc) had them as well. (I'll take them out now)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files that we add can be of different types (note that I'm kinda bs-ing this but I think this is how it works)

the events show up on the home page and under the events tab

pages are like top level thing that usually show up in our nav bar (calendar, contact us, policies, etc)

you want this to be a page because it serves the same kind of purpose as the 'contact us' page, but if you don't put status:hidden it shows up by default in the nav bar and we're having crowding problems there so the status:hidden makes it a page but a hidden page

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, Elana said you don't even need the category or summary metadata - wanna get rid of those 2 lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O.o I meant to remove it but I guess I forgot. Will do.

@fboxwala
Copy link
Contributor

fboxwala commented Jul 7, 2016

@wics-uw/contributors SO okay, I have said this a few times to people individually but I want everyone to see and understand - do not ever git pull. When you edit the commit history and try to push your branch, git will suggest that you do a git pull and that if you do not git pull you will not be able to push your branch. This is not true. What you need to do usually is this:

git fetch upstream
git rebase upstream/master
git push -f origin HEAD

If you are not sure how to proceed then ping me or Melted or Evy or e# or post in #wics-sys and we will help you out.

When you git pull you get weird stuff happening like with Arshia's commit history right now.
(sorry to call you out like this Arshia but this is a perfect learning opportunity and I didn't want to pass it up.)

Moral of the story: when working on a public shared git repository, never ever ever git pull no matter how badly git wants you to.

@arshiamufti
Copy link
Contributor Author

Imo it's useful to add this^ to the readme of the website too.

* We’ll help you advertise it, book rooms for it, order food for it under our budget.
* **Commitment:** 5-6 hours spread out over around 10 days.
* Here are some examples of what you can do:
- Bring in a potential speaker to give a talk.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you start this list with lower case and not end in periods, like the list directly above it?

@evykassirer
Copy link
Member

other than line length and the extra metadata, it's looking good to me!

@evykassirer
Copy link
Member

this is almost done - when can you make the final changes by?

@ehashman ehashman temporarily deployed to wics-site-pr-215 July 11, 2016 14:07 Inactive
@ehashman ehashman temporarily deployed to wics-site-pr-215 July 12, 2016 02:52 Inactive
@@ -41,4 +41,6 @@ but let us know if you would like to
+ Represent undergraduate interests on the Women in Computer Science Committee
+ Represent WiCS at student government meetings

You can **sign up** or read more about our volunteer opportunities [here]({filename}/pages/volunteers.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is still too long

@evykassirer
Copy link
Member

last two lines need to be shorter, otherwise all ready! so hyped to merge this!!!

@arshiamufti
Copy link
Contributor Author

should be fixed now (i think)

@ehashman ehashman temporarily deployed to wics-site-pr-215 July 12, 2016 03:05 Inactive
### Run an event with us!

* **You** have to reach out to us [by
* email](mailto:wics-ugrad@lists.uwaterloo.ca) with an event that you’d like to
Copy link
Member

@evykassirer evykassirer Jul 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the * at the beginning of this line breaks this (see https://wics-site-pr-215.herokuapp.com/volunteer-opportunities/) 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ackkkk my bad >:(

@ehashman ehashman temporarily deployed to wics-site-pr-215 July 12, 2016 03:57 Inactive
@evykassirer
Copy link
Member

OKAY looks good!! can you squash the commits now?

@arshiamufti
Copy link
Contributor Author

will do
(clicking on the heroku link prompts me for log in..?)

@evykassirer
Copy link
Member

evykassirer commented Jul 12, 2016

you were probably clicking on the wrong link (don't click deployed, click wics-site-pr-215)

try this one https://wics-site-pr-215.herokuapp.com/

@arshiamufti
Copy link
Contributor Author

i squashed a thing did it work?

read about our current volunteer opportunities
[here]({filename}/pages/volunteers.md)!

## Do you have resources to learn more about women in tech? ##
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dang this shouldn't be here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i think i accidentally formatted some other stuff. Uh what should I do to fix it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatted what other stuff?

the problem I saw was that the resources question was duplicated - so to fix it you can just delete one of the duplicated paragraphs

@evykassirer
Copy link
Member

screen shot 2016-07-12 at 1 58 59 pm yeah it's all one commit!

but you actually have something else to fix woops
so fix it and then squash and hopefully that's it

@ehashman ehashman temporarily deployed to wics-site-pr-215 July 12, 2016 18:03 Inactive
fixes tabbing, improves content in volunteer page

fixes line width and formatting in bullet points

fixes line length in about and faq pages

fixes syntax error on volunteer page

removes duplicate FAQ
@@ -8,7 +8,8 @@ out]({filename}/pages/contact.md) to us!

## What does “women-only” mean? ##

Our women-only events are open to cis and trans women, and non-binary individuals.
Our women-only events are open to cis and trans women, and non-binary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's kinda weird that there were changes about non volunteer stuff in this diff, but I don't think it's a huge deal and it's nice to have the line lengths adjusted better

@ehashman ehashman temporarily deployed to wics-site-pr-215 July 13, 2016 20:26 Inactive
@evykassirer
Copy link
Member

looks 💯 good to me!

🎉 🎆 🎈 ❗ 😃 💯 🚀

thanks for all your work on this @arshiamufti ❤️ twas a big task you took on

I'm so excited to have this information on our website

@evykassirer evykassirer merged commit 38921ef into wics-uw:master Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants