This repository has been archived by the owner on May 12, 2021. It is now read-only.
Set bgfx PROJECT_VERSION from bgfx versioning scheme. #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bgfx has a versioning scheme as defined here: https://github.com/bkaradzic/bgfx/blob/master/src/bgfx.cpp#L3439-L3444
We can generate this all ourself from Git / reading files as done in
cmake/version.cmake
.It's important to set a version so package install targets work properly, plus it's quite vital to track the API_VERSION since it seems to change for breaking changes - I intend to lock to specific API_VERSIONs on my own project to avoid drastic breaking changes all the time.
Another thing that can be done but isn't currently is auto generating version.h so bgfx internally knows it's version number. (Seems like this autogenerated file is committed sporadically so it's inaccurate as is).