Minimap improvements

[hessenfarmer]

Type of change
New feature

Issue(s) closed
fixes #1781, fixes #2144, fixes #4466, fixes #2074

New behavior
Signal busy roads and flags with more then 5 wares on the minimap in the inverse color

How it works
Determine whether a flag or road is busy and inverse the display color

Possible regressions
Minimap visibilty

Screenshots

Additional context
things that still need implementation

• make traffic overlay switchable
• fix contrast between layers and playercolors (Minimap: Terrain and owner layers lack contrast #4466)
• highlight Buildings under attack (Highlight buildings under attack on the minimap #2074)
• eventually highlight specific buildings (Highlight specific buildings on the minimap #5654)

[Noordfrees]

Looks good :)
Code LGTM, one comment inline

[Noordfrees]

But maybe we should not draw this information about roads and flags belonging to enemy players?

[hessenfarmer]

But maybe we should not draw this information about roads and flags belonging to enemy players?

We draw only what is in our visibility, imho. So if we would see it in real, near the border we could safely draw it in the minimap as well. But I am open for others opinions on this.

[hessenfarmer]

ok, first problem where I might need some help:

how to identify a building which is attacked

[Noordfrees]

Buildings do not currently have a concept of "under attack". When a soldier approaches an enemy militarysite, he notifies the site's attack target, which may choose to send out some defenders early and perhaps send a message. But the fact of the attack is not cached anywhere. This would need some non-trivial changes to militarysite and soldier code to implement properly.

---

Alternatively, how about instead highlighting the positions of soldiers who are currently in the process of attacking or defending something?

for (Widelands::Bob* bob = field->get_first_bob(); bob != nullptr; bob = bob->get_next_bob()) {
	if (bob->descr()->type() == Widelands::MapObjectType::SOLDIER && dynamic_cast<Widelands::Soldier*>(bob)->is_on_battlefield()) {
		color = ...;
		break;
	}
}

[hessenfarmer]

Buildings do not currently have a concept of "under attack". When a soldier approaches an enemy militarysite, he notifies the site's attack target, which may choose to send out some defenders early and perhaps send a message. But the fact of the attack is not cached anywhere. This would need some non-trivial changes to militarysite and soldier code to implement properly.

Alternatively, how about instead highlighting the positions of soldiers who are currently in the process of attacking or defending something?

for (Widelands::Bob* bob = field->get_first_bob(); bob != nullptr; bob = bob->get_next_bob()) {
	if (bob->descr()->type() == Widelands::MapObjectType::SOLDIER && dynamic_cast<Widelands::Soldier*>(bob)->is_on_battlefield()) {
		color = ...;
		break;
	}
}

nice idea will try to use that

[Noordfrees]

The high traffic suppression for other players isn't working

owner is the owner of the current field, you instead want to compare with the player number of the interactive player. If there is no interactive player (i.e. spectator) then showing it for all players is fine.

[hessenfarmer]

The high traffic suppression for other players isn't working
owner is the owner of the current field, you instead want to compare with the player number of the interactive player. If there is no interactive player (i.e. spectator) then showing it for all players is fine.

stupid mistake. Thanks for the help. should be fixed now

[Noordfrees]

This fixed it for flags but the fix needs to be applied to roads as well

[hessenfarmer]

sorry I cant concentrate well today

[Noordfrees]

Thanks, working great now :)