Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Int Number Knob #430

Closed
jiwon79 opened this issue Jan 31, 2023 · 4 comments · Fixed by #942
Closed

Int Number Knob #430

jiwon79 opened this issue Jan 31, 2023 · 4 comments · Fixed by #942
Assignees
@Mastersam07
Labels
hacktoberfest m: knobs p: core Related to `widgetbook` package t: feat New feature or request

Comments

@jiwon79
Copy link

jiwon79 commented Jan 31, 2023

I would like to suggest the following two things.

  1. Add knob for integer
    Currently, there is a knob that only input num type variable. Like html input number tag, I want a button that can increate the number by 1 with the arrow next to input box.

  2. Add minium and maximun parameter for num knob
    It would be nice if there are parameters that ignore value below the minimun value and above the maximun value.
@jenshor jenshor changed the title feat: integer, number knob feat: integer number knob Feb 7, 2023
@jenshor jenshor added the t: feat New feature or request label Feb 7, 2023
@jenshor jenshor mentioned this issue Mar 21, 2023
Closed
@yousinix yousinix changed the title feat: integer number knob Int Number Knob Sep 20, 2023
@yousinix yousinix added p: core Related to `widgetbook` package m: knobs good first issue labels Sep 20, 2023
@Mastersam07
Copy link
Contributor

Mastersam07 commented Oct 6, 2023 •
edited
Loading

Is this being worked on?

I am trying to code out some ideas for #17 but i could really use an IntField which i believe working on this issue would add?

@Mastersam07
Copy link
Contributor

Mastersam07 commented Oct 6, 2023 •
edited
Loading

@YoussefRaafatNasry if this is not assigned, i could pick it up

@Mastersam07 Mastersam07 mentioned this issue Oct 6, 2023
Merged
5 tasks
@yousinix yousinix linked a pull request Oct 8, 2023 that will close this issue
feat: add int knob #942
Merged
5 tasks
@MarkOSullivan94
Copy link

When will this be added to a release?

@yousinix
Copy link
Member

yousinix commented Nov 1, 2023

@MarkOSullivan94 The release will be ready early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mastersam07 Mastersam07

Labels
hacktoberfest m: knobs p: core Related to `widgetbook` package t: feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add int knob Mastersam07/widgetbook
5 participants
@MarkOSullivan94 @jenshor @Mastersam07 @yousinix @jiwon79