feat: add int knob

[Mastersam07]

• Add Int number knob.
• Add generic NumXField.
• IntXField and DoubleXField extending generic NumXField

List of issues which are fixed by the PR

#430

Screenshots

int_knob.mov

Checklist

• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making].
• All existing and new tests are passing.

If you need help, consider asking for advice on Discord.

[Mastersam07]

Hi @YoussefRaafatNasry can you please take a look/review?

[YoussefRaafatNasry]

While this implementation is well-crafted, but we are looking into feature-parity between double and int knobs (i.e knobs.int.slider, knobs.int.input, etc.).

This will result into a lot of duplicated code between the DoubleXField and IntXField, so can you explore the possibility of creating a generic NumSilderField<T extends num> and NumInputField<T extends num> that can be used for both int and double knobs?

[Mastersam07]

While this implementation is well-crafted, but we are looking into feature-parity between double and int knobs (i.e knobs.int.slider, knobs.int.input, etc.).

This will result into a lot of duplicated code between the DoubleXField and IntXField, so can you explore the possibility of creating a generic NumSilderField<T extends num> and NumInputField<T extends num> that can be used for both int and double knobs?

Does this mean we end up with only NumXField or we still maintain DoubleXField and IntXField but with shared code in the NumXField?

[YoussefRaafatNasry]

Does this mean we end up with only NumXField or we still maintain DoubleXField and IntXField but with shared code in the NumXField?

@Mastersam07 We will maintain all 6 classes (NumSliderField, NumInputField,DoubleSliderField, DoubleInputField, IntSliderField, IntInputField). The base class will have all the shared logic, the child classes will only extend it without having too much code to maintain.

[Mastersam07]

Does this mean we end up with only NumXField or we still maintain DoubleXField and IntXField but with shared code in the NumXField?

@Mastersam07 We will maintain all 6 classes (NumSliderField, NumInputField,DoubleSliderField, DoubleInputField, IntSliderField, IntInputField). The base class will have all the shared logic, the child classes will only extend it without having too much code to maintain.

Alright. Made the changes.

[Mastersam07]

@YoussefRaafatNasry please review

[YoussefRaafatNasry]

@Mastersam07 Apology for this taking time, but I have it in my queue, no need to worry about it.
We have high activity for Hacktoberfest, along with our other tasks, so it might take a day or two to review (excluding weekends)

[Mastersam07]

@YoussefRaafatNasry the conflict is due to places like this that were specified as type int. There is no conflict with double because no variable/args is specified as type double.

[YoussefRaafatNasry]

@Mastersam07 makes sense.
Let's go with integer / integerOrNull.
I feel like we are also going to run into the same problem later with double, but let's wait and see.

[YoussefRaafatNasry]

@Mastersam07 Nevermind the last comment. I have came up with an idea as a workaround, because I am more leaning towards the int name over integer.

You can add a typedef at the top of the file as follows:

typedef $int = int;

Then we name IntKnobsBuilder as int
and any int parameter as $int

[Mastersam07]

@Mastersam07 Nevermind the last comment. I have came up with an idea as a workaround, because I am more leaning towards the int name over integer.

You can add a typedef at the top of the file as follows:

typedef $int = int;

Then we name IntKnobsBuilder as int and any int parameter as $int

Alright. Made the changes.

[YoussefRaafatNasry]

Another interesting PR, thanks a lot @Mastersam07 for improving Widgetbook! 💙