-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add grid addon #943
feat: add grid addon #943
Conversation
Hi @YoussefRaafatNasry can you please take a look/review? This depends partly on #942 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the changes requested, we can detach this PR from the int
knob PR, so we can merge each once separately.
Let me know what you think about the proposed changes and if you have any better ideas to improve this.
fbd93b5
to
ac383e8
Compare
@YoussefRaafatNasry changes made accordingly. |
packages/widgetbook/lib/src/addons/grid_addon/grid_painter.dart
Outdated
Show resolved
Hide resolved
packages/widgetbook/lib/src/addons/grid_addon/grid_painter.dart
Outdated
Show resolved
Hide resolved
packages/widgetbook/lib/src/addons/grid_addon/grid_setting.dart
Outdated
Show resolved
Hide resolved
@YoussefRaafatNasry changes made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Mastersam07! Keep it up with the awesome PRs 💙
There will be some trivial changes (style, rewording in docs/Changelog) that I will do before merging this. The reason I will be doing them instead of adding comments is because:
- They are nit-picks that you should not bother with, and focus more on your other PRs.
- We have a lot of Hacktoberfest activity going on, and I am trying to minimize the back and forth on PRs.
I would still advice that you have a look on them, and feel free to ask any question them if needed.
Alright. Went through the changes, pretty straightforward. No questions |
Add grid addon.
This addon draws a grid on the widgetbook canvas. Where there is a
DeviceFrameAddon
, the grid is drawn on the device frame.Seems like a good approximation of #17. Fields added to specify horizontal and vertical grid spacing.
Usage
To use grid on device, the
DeviceFrameAddon
must come beforeGridAddon
in the addons hierarchy.List of issues which are fixed by the PR
#17
Screenrecord
Grid on widgetbook canvas
grid.mp4
Grid on device frame
device_grid.mp4
Checklist
///
).If you need help, consider asking for advice on Discord.