Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: offline=True kwarg in embed_html was failing to save dependency jupyter-threejs.js #198

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

BUGFIX: offline=True kwarg in embed_html was failing to save dependency jupyter-threejs.js #198

wants to merge 8 commits into from

Commits on Oct 31, 2018

  1. Add development copy of file https://unpkg.com/jupyter-threejs@2.0.1/… 

    …dist/index.js
    @GenevieveBuckley
    GenevieveBuckley committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    a32bc05 View commit details
    Browse the repository at this point in the history

  2. Update version number for jupyter-threejs.js dependency.

    @GenevieveBuckley
    GenevieveBuckley committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    ba94b6e View commit details
    Browse the repository at this point in the history

  3. Retrieve jupyter-threejs.js dependency for offline embedding of ipyvo… 

    …lume in a html file.
    @GenevieveBuckley
    GenevieveBuckley committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    0b7df2f View commit details
    Browse the repository at this point in the history

  4. Add docstring for save_jupyterthreejs function in embed.py

    @GenevieveBuckley
    GenevieveBuckley committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    d159f37 View commit details
    Browse the repository at this point in the history

  5. Tidy up the save_ipyvolumejs function in embed.py

    @GenevieveBuckley
    GenevieveBuckley committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    353001f View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Tidy up version numbering.

    @GenevieveBuckley
    GenevieveBuckley committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    5741162 View commit details
    Browse the repository at this point in the history

  2. save_jupyterthreejs should work like the other javascript dependency … 

    …saving functions - currently all require you to be online when you save to html.
    @GenevieveBuckley
    GenevieveBuckley committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    b3b0245 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. We are using pythreejs not threejs, make this clearer in the variable… 

    … names.
    @GenevieveBuckley
    GenevieveBuckley committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    17acb33 View commit details
    Browse the repository at this point in the history