feat: support reconnecting websocket #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
feat_reconnect
branch
3 times, most recently
from
f72b02d
to
a9f0970
Compare
Closed
maartenbreddels
force-pushed
the
feat_reconnect
branch
from
f366a02
to
c3c11f2
Compare
Instead of asking a user to refresh the browser, we let the websocket reconnect and try to restore the page session.
Each time the ipywidgets_runner fixture was used, all fixtures are used. This means the ipywidgets_runner_solara runner was also used, causing the solara_test fixture to always run and also close the app each time, which close all the contexts. This is bad for performance of the tests, but it is possibly also the cause for some flakeyness in our tests.
maartenbreddels
force-pushed
the
feat_reconnect
branch
from
77e8989
to
5227429
Compare
|
@CodiumAI-Agent /describe |
maartenbreddels
force-pushed
the
master
branch
4 times, most recently
from
2446983
to
0d6161d
Compare
|
superseded by #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of asking a user to refresh the browser, we let the websocket
reconnect and try to restore the page session.
Some caveats with multiple workers as explained in the documentation.
cc @lp9052