Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support reconnecting websocket #257

Closed
wants to merge 6 commits into from
Closed

feat: support reconnecting websocket #257

wants to merge 6 commits into from

Commits on Sep 29, 2023

  1. feat: support reconnecting websocket 

    Instead of asking a user to refresh the browser, we let the websocket
reconnect and try to restore the page session.
    @maartenbreddels
    maartenbreddels committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    ad38d4b View commit details
    Browse the repository at this point in the history

  2. refactor: less noisy logging when reloading modules (info->debug)

    @maartenbreddels
    maartenbreddels committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    5623a61 View commit details
    Browse the repository at this point in the history

  3. fix: we do not need special pyodide support (dead code)

    @maartenbreddels
    maartenbreddels committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a1e243f View commit details
    Browse the repository at this point in the history

  4. test: make more robust by closing previous page sessions

    @maartenbreddels
    maartenbreddels committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    4e48cc3 View commit details
    Browse the repository at this point in the history

  5. test(pytest): always resture run_calls to 0 so follow up tests do not… 

    … fail
    @maartenbreddels
    maartenbreddels committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    6abc803 View commit details
    Browse the repository at this point in the history

  6. refactor: do not run all runners in ipywidgets_runner fixture 

    Each time the ipywidgets_runner fixture was used, all fixtures
are used. This means the ipywidgets_runner_solara runner was
also used, causing the solara_test fixture to always run
and also close the app each time, which close all the contexts.

This is bad for performance of the tests, but it is possibly also
the cause for some flakeyness in our tests.
    @maartenbreddels
    maartenbreddels committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    5227429 View commit details
    Browse the repository at this point in the history