fix: solara.display not working on some mimetypes in production mode #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://solara-stable-pr-622.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-conpq1mct0pc73dk05j0. |
Collaborator
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
These dependencies were aliased to an empty file to save on bundle size in 242d7e2, but turn out to be necessary for the rendering of some mimetypes. Because the aliasing takes place during the minification step, development mode still worked, but running in production mode would show a javascript error.
iisakkirotko
force-pushed
the
04-29-fix_solara.display_not_working_on_some_mimetypes_in_production_mode
branch
from
a0539c7 to
668372f
Compare
mariobuikhuizen
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These dependencies were aliased to an empty file to save on bundle size in 242d7e2, but turn out to be necessary for the rendering of some mimetypes. Because the aliasing takes place during the minification step, development mode still worked, but running in production mode would show a javascript error.
Fixes #500.