Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 1408 (API Validation) #1469

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Bugfix/issue 1408 (API Validation) #1469

merged 2 commits into from
Dec 19, 2023

Conversation

hansmorb
Copy link
Contributor

@hansmorb hansmorb commented Dec 18, 2023

Zum Testen:
Mit bin/build-zip.sh eine Plugin ZIP erstellen und schauen, ob die API Routen mit WP_DEBUG aktiviert noch funktionieren. Wurde noch nicht manuell getestet.

closes #1408

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7ba95dd) 39.76% compared to head (152382e) 39.74%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/API/BaseRoute.php 0.00% 3 Missing ⚠️
src/API/ItemsRoute.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1469      +/-   ##
============================================
- Coverage     39.76%   39.74%   -0.03%     
- Complexity     2324     2326       +2     
============================================
  Files            91       91              
  Lines          9602     9607       +5     
============================================
  Hits           3818     3818              
- Misses         5784     5789       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hansmorb hansmorb linked an issue Dec 18, 2023 that may be closed by this pull request
@hansmorb hansmorb added bug Something isn't working quick issues with minor dependencies php Pull requests that update Php code labels Dec 18, 2023
@hansmorb hansmorb marked this pull request as ready for review December 19, 2023 14:09
@hansmorb hansmorb removed the request for review from datengraben December 19, 2023 14:09
@hansmorb hansmorb merged commit 5d480b1 into master Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working php Pull requests that update Php code quick issues with minor dependencies
Projects
None yet
1 participant