Change deprecated way of string interpolation #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"${var}" is deprecated with php 8.2. Future options are "{$var}" or the good old "$var". With simple variables, the good old variant is easier to read IMHO.
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1609 +/- ##
=========================================
Coverage 49.79% 49.79%
Complexity 2682 2682
=========================================
Files 97 97
Lines 10712 10712
=========================================
Hits 5334 5334
Misses 5378 5378 ☔ View full report in Codecov by Sentry. |
hansmorb
approved these changes
Jul 2, 2024
hansmorb
added
php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mit Bezug auf #1605 ist das Ziel dieser PR, u.g. Warningen unter WP latest PHP 8.2. loszuwerden. Statt ${var} habe ich mit der PR vorgeschlagen, einfach $var zu schreiben in Strings mit doppelten Anführungszeichen. Man könnte auch die moderne Variante {$var} nutzen, aber die ist nicht einfacher zu lesen.