-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing legacy handshakeverify extension with one that uses cowpatty #1291
base: master
Are you sure you want to change the base?
Conversation
to validate the WPA key.
This pull request introduces 2 alerts when merging 041142c into 46bdf13 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 9ae7190 into 46bdf13 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Can you also change the argument's description on pywifiphisher.py
and README.md
?
Finally, can you squash your commits into one single commit?
|
||
def is_valid_handshake_capture(filename): | ||
command = '/bin/cowpatty -c -r {}'.format(filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we return an error if cowpatty is not installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I willl accomplish it as soon as possible.
I'll fix this and merge it soon. |
Due to problems with python3 porting, I think it would be better to use a tool like cowpatty to ensure WPA key validation.