Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send server configuration data to client upon login #88

Merged
merged 1 commit into from
Feb 15, 2020

Conversation

congratulatio
Copy link
Contributor

This is for server configuration that would be useful for the client to know. Currently:

Name Description Purpose
sf Scale factor limit Client may limit or warn when its scale factor exceeds this
afk AFK disconnection timeout Client may provide a custom error message

I'm currently testing this on eu.airmash.online game servers and https://test.airmash.online client, but will revert if this PR is not a suitable approach.

sf: Scale factor limit - client may limit/warn when its scale factor exceeds this limit
afk: AFK disconnection timeout - client may provide custom error message
@wight-airmash wight-airmash changed the base branch from master to develop February 15, 2020 20:20
@wight-airmash wight-airmash merged commit ab79fb0 into wight-airmash:develop Feb 15, 2020
@congratulatio
Copy link
Contributor Author

After reading #85 (comment) I am wondering if this would be more appropriate as a new field in the LOGIN packet. Though, that does limit the configuration update to when the player joins, and in future we may want to expose a server configuration that could be changed during the game, so maybe not.

@congratulatio congratulatio deleted the server-config branch February 15, 2020 21:09
@wight-airmash
Copy link
Owner

Yes, I think it's the right place for that kind of data. In addition, SERVER_CUSTOM has the advantage over LOGIN, it can be sent unlimited number of times with updated data, but LOGIN only once.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants