Switch to {{socklist}} in SPI report (#1509)

* Switch to {{socklist}} in SPI report

Makes it easier for people to add more sox after the report is filed, and allows for a working set of tools links. Templates/modules do all of the heavy lifting. See https://en.wikipedia.org/wiki/Template_talk:SPI_report#Proposed_change_to_sock_list.

* fix lint error

modules/twinklearv.js

@@ -810,10 +810,10 @@ Twinkle.arv.processSock = function(params) {
 	Morebits.wiki.addCheckpoint(); // prevent notification events from causing an erronous "action completed"
 
 	// prepare the SPI report
-	var text = '\n{{subst:SPI report|socksraw=' +
-		params.sockpuppets.map(function(v) {
-			return '* {{' + (mw.util.isIPAddress(v, true) ? 'checkip' : 'checkuser') + '|1=' + v + '}}';
-		}).join('\n') + '\n|evidence=' + params.evidence + ' \n';
+	var text = '\n{{subst:SPI report|' +
+		params.sockpuppets.map(function(sock, index) {
+			return (index + 1) + '=' + sock;
+		}).join('|') + '\n|evidence=' + params.evidence + ' \n';
 
 	if (params.checkuser) {
 		text += '|checkuser=yes';