Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tag] Cannot add {{should be SVG}} to PNG #1108

Closed
JJMC89 opened this issue Aug 15, 2020 · 1 comment · Fixed by #1114
Closed

[tag] Cannot add {{should be SVG}} to PNG #1108

JJMC89 opened this issue Aug 15, 2020 · 1 comment · Fixed by #1114
Labels
bug Module: tag

Comments

@JJMC89
Copy link
Contributor

JJMC89 commented Aug 15, 2020

I tried to add {{should be SVG|logo}} in this edit with {{Opaque}}, but Twinkle wouldn't let me.

This appears to be a png file, please use {{Should be PNG}} instead.
Amorymeltzer added a commit to Amorymeltzer/twinkle that referenced this issue Aug 31, 2020
@Amorymeltzer
tag: Fix wrong extension check in should be templates
2770719 
From wikimedia-gadgets#1000, closes wikimedia-gadgets#1108
@Amorymeltzer Amorymeltzer mentioned this issue Aug 31, 2020
Merged
@Amorymeltzer
Copy link
Collaborator

I'm an idiot

Amorymeltzer added a commit to Amorymeltzer/twinkle that referenced this issue Sep 16, 2020
@Amorymeltzer
tag: Fix bug disallowing Bad trace on SVGs
900fdd8 
Stems from wikimedia-gadgets#1000 (see also wikimedia-gadgets#1108/wikimedia-gadgets#1114).  Basically, in wikimedia-gadgets#1000 I naively set tag up to check for uses of {{Bad (ext)}} whilst simultaneously forgetting that {{Bad Trace}} and {{Bad font}} were a thing.  This should also improve the message by correctly identifying when an appropriate option is available.

Reported at WT:TW: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Twinkle&oldid=978523110#Unable_to_add_Template:Bad_trace

This all needs work anyway.
@Amorymeltzer Amorymeltzer mentioned this issue Sep 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Module: tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tag: Fix wrong extension check in should be templates Amorymeltzer/twinkle
2 participants
@Amorymeltzer @JJMC89