tag: Disallow conflicting file tags and use functions to validate #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to the validation done in article mode. Requested at https://en.wikipedia.org/wiki/Wikipedia_talk:Twinkle/Archive_42#Mutually_exclusive_tags
Amorymeltzer
commented
Jun 26, 2020
`checkIncompatible` and `checkParameter` should make the repetitive validations easier
Amorymeltzer
force-pushed
the
tag-mutuals
branch
from
9ac7c08
to
959d0ff
Compare
|
Unrelated, but woo, 1000 issues/PRs! |
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Aug 31, 2020
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Sep 16, 2020
Stems from wikimedia-gadgets#1000 (see also wikimedia-gadgets#1108/wikimedia-gadgets#1114). Basically, in wikimedia-gadgets#1000 I naively set tag up to check for uses of {{Bad (ext)}} whilst simultaneously forgetting that {{Bad Trace}} and {{Bad font}} were a thing. This should also improve the message by correctly identifying when an appropriate option is available. Reported at WT:TW: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Twinkle&oldid=978523110#Unable_to_add_Template:Bad_trace This all needs work anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit disallows some conflicting file tags, as requested at WT:TW. There are probably more we could do, this covers:
2nd commit uses
checkIncompatibleandcheckParameterto make the repetitive validation measures more straightforward.