Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put TW menu back on the right side of the More menu #1886

Closed
NovemLinguae opened this issue Nov 4, 2023 · 0 comments · Fixed by #1887
Closed

Put TW menu back on the right side of the More menu #1886

NovemLinguae opened this issue Nov 4, 2023 · 0 comments · Fixed by #1887
Labels
Module: twinkle The twinkle.js global gadget file

Comments

@NovemLinguae
Copy link
Member

In #1881 where we did some code simplification, the TW menu moved from the right of the More/Tools menu to the left.

At the time I decided it wasn't worth the code complexity to put it on the right.

I think I have changed my mind. Because now I am noticing that putting it on the left causes the More menu to shift about one second after page loading.

There's also muscle memory issues of people used to TW being on the right. I encountered this myself when I went to click on something.
@NovemLinguae NovemLinguae added the Module: twinkle The twinkle.js global gadget file label Nov 4, 2023
NovemLinguae added a commit to NovemLinguae/twinkle that referenced this issue Nov 4, 2023
@NovemLinguae
twinkle: Put TW menu back on the right side of the More menu
84aad5d 
Fixes wikimedia-gadgets#1886
Related wikimedia-gadgets#1881
@NovemLinguae NovemLinguae mentioned this issue Nov 4, 2023
Merged
NovemLinguae added a commit that referenced this issue Nov 23, 2023
@NovemLinguae
twinkle: Put TW menu back on the right side of the More menu (#1887)
6e30957 
* twinkle: Put TW menu back on the right side of the More menu

Fixes #1886
Related #1881

* use var instead of let

* comment

* fix double element bug

* log, fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module: twinkle The twinkle.js global gadget file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

twinkle: Put TW menu back on the right side of the More menu NovemLinguae/twinkle
1 participant
@NovemLinguae