Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twinkle: Put TW menu back on the right side of the More menu #1887

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

NovemLinguae
Copy link
Member

@NovemLinguae NovemLinguae commented Nov 4, 2023

Fixes #1886
Related #1881

Menus are jumping around too much during page load with TW menu on the left. Need to move it back to its spot on the right.

The spot on the right is reserved for it in https://en.wikipedia.org/wiki/MediaWiki:Gadget-Twinkle.css

@github-actions github-actions bot added the Module: twinkle The twinkle.js global gadget file label Nov 4, 2023
@NovemLinguae
Copy link
Member Author

@jdlrobson. Can you code review this one?

twinkle.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jdlrobson jdlrobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to merge this before the deployment or is the plan to see if people care about this enough first?

Another solution that did occur to me is a CSS only solution like so:

#p-twinkle { order: 2; } 

This might be easier to maintain?

twinkle.js Outdated Show resolved Hide resolved
twinkle.js Outdated Show resolved Hide resolved
twinkle.js Outdated Show resolved Hide resolved
twinkle.js Show resolved Hide resolved
@NovemLinguae NovemLinguae merged commit 6e30957 into wikimedia-gadgets:master Nov 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: twinkle The twinkle.js global gadget file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put TW menu back on the right side of the More menu
2 participants