speedy/xfd: Handle non-wikitext contentmodels #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amorymeltzer
commented
Nov 23, 2020
| params.tagText += params.templatetype === 'standard' || params.templatetype === 'sidebar' ? '\n' : ''; // No newline for inline | ||
| } | ||
|
|
||
| if (pageobj.canEdit() && ['wikitext', 'sanitized-css'].indexOf(pageobj.getContentModel()) !== -1) { |
There was a problem hiding this comment.
These three make use of the autoEditRequest from #1091, but it means that the language is currently saying that the page was protected, which is wrong. Is it excessive to create a new template just for this? We could do a separate if (and function?) like is done for twinklespeedy.js in this PR and not rely on that functionality. Alternatively, adding a parameter to the function could allow for a bespoke message, but it's not currently easy to detect protection status, so a less good option overall.
Place tag within comment block on js/css pages, put on talk page otherwise (per instructions). As written, depends on `getContentModel`, need not.
- tfd: sanitized-css (Scribunto already goes on /doc) - mfd: json, javascript, css, sanitized-css
Amorymeltzer
force-pushed
the
speedy-weirdos
branch
from
131a106
to
92d092a
Compare
Closed
siddharthvp
added a commit
that referenced
this pull request
Dec 20, 2020
(handling of non-wikitext content models)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, try to deal with most of #745 as far as Twinkle is concerned (basically, not MML), albeit somewhat naïvely. Imperfect, so wouldn't mind some feedback (cc @DannyS712 and @siddharthvp)
(1st commit: Not strictly a contentmodel issue, but post CSD on talk if can't edit (basically, #1091 but for CSD))
2nd commit: speedy: Place tag in comment block for
javascript,css, andsantized-csscontent models, otherwise place on talkpage (as per instructions) (scribunto already handled in #1121)3rd commit: xfd:
sanitized-css(scribunto goes on /doc per instructions)javascript,css, andsanitized-cssAs written, depends on #1201 but need not.