xfd: Avoid client clock for soft redirects #863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In doing #862, I undid the intent of #714 to avoid the client clock as much as possible for the specific case of soft redirects being nominated at RfD. It never worked - thus #861 - but the idea is sound. This has softredirects go through the same
curtimestamp
query and "typical" redirects, but simply skips processing of target or section. It's not a free check anymore, but it should be incredibly infrequent and fairly quick.Also added a note for softredirect failures from the history tab. If run from history, the
Morebits.wiki.isPageRedirect
check for soft redirects won't work. The module fails fine, but a note suggesting users retry from the content tab is helpful.