Failed to list a soft redirect at RFD #861
Assignees
Labels
Comments
|
Thanks for the report @evad37: I've got a fix for this, and another issue I discovered while testing it coming up soon. |
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this issue
Feb 21, 2020
1. Since wikimedia-gadgets#741 (specifically, 3e21765), RfD was using a returned `curtimestamp` to generate the log page. That query was only being done if the page wasn't a soft redirect, however, leading to NaN/undefined issues. Closes wikimedia-gadgets#861 by falling back to the previous client clock method. 2. wikimedia-gadgets#527 (44c0e42) added the ability to notify a redirect's target, but returns an error if the title is invalid, such as with soft redirects via {{wi}}. This now skips the notification in such cases.
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this issue
Feb 21, 2020
In doing wikimedia-gadgets#862, I undid the intent of wikimedia-gadgets#714 to avoid the client clock as much as possible for the specific case of soft redirects being nominated at RfD. It never worked - thus wikimedia-gadgets#861 - but the idea is sound. This has softredirects go through the same `curtimestamp` query and "typical" redirects, but simply skips processing of target or section. It's not a free check anymore, but it should be incredibly infrequent and fairly quick.
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this issue
Mar 2, 2020
In doing wikimedia-gadgets#862, I undid the intent of wikimedia-gadgets#714 to avoid the client clock as much as possible for the specific case of soft redirects being nominated at RfD. It never worked - thus wikimedia-gadgets#861 - but the idea is sound. This has softredirects go through the same `curtimestamp` query and "typical" redirects, but simply skips processing of target or section. It's not an entirely free check anymore, but it should be incredibly infrequent and fairly quick.
wiki-ST47
pushed a commit
to wiki-ST47/twinkle
that referenced
this issue
Sep 2, 2020
1. Since wikimedia-gadgets#741 (specifically, 3e21765), RfD was using a returned `curtimestamp` to generate the log page. That query was only being done if the page wasn't a soft redirect, however, leading to NaN/undefined issues. Closes wikimedia-gadgets#861 by falling back to the previous client clock method. 2. wikimedia-gadgets#527 (44c0e42) added the ability to notify a redirect's target, but returns an error if the title is invalid, such as with soft redirects via {{wi}}. This now skips the notification in such cases.
wiki-ST47
pushed a commit
to wiki-ST47/twinkle
that referenced
this issue
Sep 2, 2020
In doing wikimedia-gadgets#862, I undid the intent of wikimedia-gadgets#714 to avoid the client clock as much as possible for the specific case of soft redirects being nominated at RfD. It never worked - thus wikimedia-gadgets#861 - but the idea is sound. This has softredirects go through the same `curtimestamp` query and "typical" redirects, but simply skips processing of target or section. It's not an entirely free check anymore, but it should be incredibly infrequent and fairly quick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See the history of Megathread and the talk page, and JzG's contributions for 11 Feb. It seems Twinkle tried to list the discussion on a nonexistent subpage [[Wikipedia:Redirects for discussion/Log/NaN undefined NaN]] - it didn't create that page, but did add the nomination template with that link in the edit summary, and the same with the author notification. After adding a fake #REDIRECT to the page Twinkle worked as expected.
The text was updated successfully, but these errors were encountered: