Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluff: Fix revert coming from contribs if diffonly is used #914

Merged
merged 1 commit into from
Apr 12, 2020
Merged

fluff: Fix revert coming from contribs if diffonly is used #914

merged 1 commit into from
Apr 12, 2020

Commits on Apr 7, 2020

  1. fluff: Fix revert coming from contribs if diffonly is used 

    Fixes wikimedia-gadgets#913, same basic issue as wikimedia-gadgets#627/wikimedia-gadgets#628: if a user has "Do not show page content below diffs" selected in Special:Preferences, wgRevisionId is set to 0 on diffs.  While wikimedia-gadgets#628 took care of that for the links on diff pages themselves, trying to rollback from a contribs page was left unfixed.  Those links load the diff page then `auto`matically revert, so will run into the same issue.  This essentialy reverts back to the check before 3e5ec5b (wikimedia-gadgets#561), albeit by using `mw.util.getParamValue` rather than the no-longer-existing `Morebits.queryString.get` (wikimedia-gadgets#725).
    @Amorymeltzer
    Amorymeltzer committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    5f1a0c2 View commit details
    Browse the repository at this point in the history