Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not displaying in XFDs viewed with older skins #44

Closed
NovemLinguae opened this issue May 29, 2024 · 0 comments · Fixed by #47
Closed

not displaying in XFDs viewed with older skins #44

NovemLinguae opened this issue May 29, 2024 · 0 comments · Fixed by #47

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented May 29, 2024 •
edited
Loading

Reported by Daniel at https://en.wikipedia.org/wiki/Wikipedia_talk:XFDcloser#XFDcloser_links_vanishing_in_old_skins

Major regression

Steps to reproduce

  • Visit an unclosed AFD, TFD, CFD, RFD, FFD
  • Add ?useskin=monobook to the URL. Reload the page.

What happens?

  • DiscussionView links ("Close", "quickClose", etc.) missing
image

What should happen instead?

  • DiscussionView links ("Close", "quickClose", etc.) present
image
@NovemLinguae NovemLinguae changed the title not displaying in AFDs viewed with the Monobook skin not displaying in XFDs viewed with the Monobook skin May 29, 2024
NovemLinguae added a commit to NovemLinguae/xfdcloser that referenced this issue May 29, 2024
@NovemLinguae
fix monobook
e441e75 
fixes wikimedia-gadgets#44
@NovemLinguae NovemLinguae mentioned this issue May 29, 2024
Merged
@NovemLinguae NovemLinguae changed the title not displaying in XFDs viewed with the Monobook skin not displaying in XFDs viewed with older skins Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix old skins broken by MediaWiki heading HTML changes NovemLinguae/xfdcloser
1 participant
@NovemLinguae