Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix old skins broken by MediaWiki heading HTML changes #47

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

NovemLinguae
Copy link
Member

fixes #44

@NovemLinguae NovemLinguae requested a review from evad37 May 29, 2024 15:19
@NovemLinguae
Copy link
Member Author

Note to self: the XFDCloser documentation says that it also supports Modern and Timeless, but I think those are also broken. Maybe I should try to patch those here as well.

Root cause is probably https://www.mediawiki.org/wiki/Heading_HTML_changes

image

@NovemLinguae NovemLinguae changed the title fix monobook fix old skins broken by MediaWiki heading HTML changes Jun 2, 2024
Copy link
Collaborator

@evad37 evad37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your interest in contributing/maintaining code, I don't really have time to these days. Please go ahead with any changes you want to make, the deployment steps in https://github.com/wikimedia-gadgets/xfdcloser?tab=readme-ov-file#deployment and https://github.com/wikimedia-gadgets/xfdcloser/blob/master/bin/deploy.js should be fairly self-explanatory

@NovemLinguae
Copy link
Member Author

@evad37 Sounds good. Thanks for the reply and for making the tool. I've got enough access (wikimedia-gadgets member, interface admin) to do some maintenance on it, and it sounds like you're OK with it, so I'll go ahead and see what I can do. Be well my friend :)

@NovemLinguae NovemLinguae merged commit ef5bbe7 into wikimedia-gadgets:master Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not displaying in XFDs viewed with older skins
2 participants