Add Less CSS preprocessing engine, some refactoring #4
Conversation
| $options = array( 'cache_dir' => APP_ROOT . '/src/Less/cache' ); | ||
| $cssFileName = Less_Cache::Get( $lessFiles, $options ); | ||
| $slim->response->headers->set( 'Content-Type', 'text/css' ); | ||
| $slim->response->setBody( file_get_contents( APP_ROOT . '/src/Less/cache/' . $cssFileName ) ); |
There was a problem hiding this comment.
This is where the magic happens. Requests to index.css will have to go through the stack, but the file is cached until the .less file is changed, so this should have no noticeable affect on page load time. This is how it is done in ResourceLoader. Normally we could just add these 5 lines of code within a <?php block in the <head> tag of our HTML, but here we can't because we're using Twig, which does not interpret PHP. We could create a Twig function that we could reference in the template, but it's essentially the same effect, except here we're taking out that small amount of Twig processing.
We only need to compile index.less. Within that file we can import Bootstrap or any other Less files, but saving that for another PR :)
I could not get a /css/index.css route to work, for whatever reason. I figure index.css works just as well, especially since once we start using bootstrap.less we'd only have one .css file anyway.
|
|
||
| // make this easier when working locally | ||
| $numRecords = $_SERVER['HTTP_HOST'] === 'localhost' ? 5 : 50; | ||
| return $this->dao->getPlagiarismRecords( $numRecords, $filter, $filterUser ); |
There was a problem hiding this comment.
We had talked about how we prefer to change to a lower number of records when working locally, so I figure this would be a handy dandy way to automate it. I've forgotten to change the 5 back to 50 a number of times now.
Some refactoring in CopyPatrol.php
Why use Less?
saveState.status-divthat represents the triage state. From there we can use Bootstrap.less (not included in this PR, but easy to add) to extend the necessary classes and get the styles we want. So we have the initial state, but on:hoverwe just extend a different Bootstrap class. A few lines of code instead of a bunch of lines of code that need refactoring, but we can't refactor because native CSS prevents any attempt at being DRYindex.cssfile is cached, and is only regenerated when the Less files change (so once per deploy)