Skip to content
This repository has been archived by the owner on Jul 5, 2018. It is now read-only.

(bug 39056) Respect system language when loading messages #101

Merged
merged 3 commits into from Aug 13, 2012

Conversation

yuvipanda
Copy link
Contributor

Load messages in the actual system language, do not hard code to english.

@bvibber
Copy link
Contributor

bvibber commented Aug 6, 2012

As I recall, it restarts the app but the user-agent string doesn't update... or something horrible like that. :) Needs testing anyway.

@jdlrobson
Copy link
Member

Add tests...? :-)

@yuvipanda
Copy link
Contributor Author

And ponies? :P

@yuvipanda
Copy link
Contributor Author

So, brion's right - the user agent string doesn't update for a while :( I've updated this to use the Globalization Plugin we're using on Wikipedia app :)

@jdlrobson
Copy link
Member

We need to write more tests for this sort of thing. Just as a mother tells us to brush our teeth to avoid our teeth looking British we need to write tests so the internet doesn't explode. I am your mother :p

@yuvipanda
Copy link
Contributor Author

Why did I google image search British Teeth? /me scrubs screen with sandpaper

@yuvipanda
Copy link
Contributor Author

@jdlrobson I'm wondering how a test for this would be implemented, since the basic 'problem'/'functionality' was how the app would cope when the language is changed mid-way (Android restarts the app).

/nick TestingNoobie

@jdlrobson
Copy link
Member

D/CordovaLog( 2958): Uncaught Error: Load timeout for modules: ../android/globalization
D/CordovaLog( 2958): http://requirejs.org/docs/errors.html#timeout
D/CordovaLog( 2958): file:///android_asset/www/js/require-jquery.js: Line 1635 : Uncaught Error: Load timeout for modules: ../android/globalization
D/CordovaLog( 2958): http://requirejs.org/docs/errors.html#timeout

Forgot to add a file?

@yuvipanda
Copy link
Contributor Author

Added the missing file.

yllierop added a commit that referenced this pull request Aug 13, 2012
(bug 39056) Respect system language when loading messages
@yllierop yllierop merged commit 1b5835a into wikimedia:master Aug 13, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants