Skip to content
This repository has been archived by the owner on Jul 5, 2018. It is now read-only.

Bug39630 - native density and aspect ratio for list thumbnails #187

Closed
wants to merge 2 commits into from
Closed

Bug39630 - native density and aspect ratio for list thumbnails #187

wants to merge 2 commits into from

Conversation

bvibber
Copy link
Contributor

@bvibber bvibber commented Aug 26, 2012 

Make thumbnail images use native aspect ratio in lists

Uses window.devicePixelRatio to load "64x64" thumbnails at appropriate size 

Also fixes aspect ratio for incomplete uploads.

@bvibber
Make thumbnail images use native aspect ratio in lists
54d52d0
@bvibber
Bug 39630: use native resolution for thumbnails in lists
101cedc 
Uses window.devicePixelRatio to load "64x64" thumbnails at appropriate size for the backing store on the device, making for sharper thumbnails.

Also fixes aspect ratio for incomplete uploads.
jdlrobson
jdlrobson reviewed Aug 27, 2012
View reviewed changes
assets/www/js/app.js
var monumentTemplate = templates.getTemplate('monument-list-item-template');
var listThumbFetcher = commonsApi.getImageFetcher(64, 64);
var monumentTemplate = templates.getTemplate('monument-list-item-template');
var listThumbFetcher = commonsApi.getImageFetcher(thumbSize, thumbSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace - please clean up.

@jdlrobson jdlrobson closed this Aug 27, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bvibber @jdlrobson