This repository has been archived by the owner on Jul 5, 2018. It is now read-only.
Bug 39571: truncate long filenames #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var months = [ 'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sept', 'Oct', 'Nov', 'Dec' ]; | ||
| var suffix = d.getDate() + months[ d.getMonth() ] + d.getFullYear() + ' ' + d.getHours() + 'hrs' + d.getMinutes() + 'mins' + d.getSeconds() + 'secs'; | ||
| return name.replace( /[\x7f\.\[#<>\[\]\|\{\}]/g, '-' ) + ' (taken on ' + suffix + ').jpg'; | ||
| function pad(str, len) { |
|
Looks good but a few bits of refactoring (and please do these as fixups during a rebase) before merging please. |
* Adds trimUtf8String function to utils.js, with some test cases. * strip more evil chars from filenames * changes filename format to "[truncated filtered name] YYYY-MM-DD HH-MM-SS.jpg" * truncates to fit filenames in 240 UTF-8 bytes, cut in half, with extra wiggle room for thumb stuff Includes a test case with a super long monument name from Belarus, and some quick tests for the truncation itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a test case with a super long monument name from Belarus.