This repository has been archived by the owner on Jul 5, 2018. It is now read-only.
Bug/38282 #51
Closed
Bug/38282 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modifies python script to capture full campaign data rather than limited subset * Python script now stores campaign data in a dict before dumping to json * Updates campaigns-data.js to latest full campaign data * Campaign data structure now made up of keyed objects, campaign name is key * Campaign sorting by alpha now happens in the template
* upload.js now required in app.js * updated formatUploadDescription() to specs in bug 38283
| @@ -16,7 +16,7 @@ | |||
| </head> | |||
| <body class='hidden'> | |||
| <script type="text/html" id="country-list-template"> | |||
| <% _.each(countries, function( country ) { %> | |||
| <% _.each( _.sortBy( countries, function(country) { return country.desc }), function( country ) { %> | |||
There was a problem hiding this comment.
Can't we sort this in python? One-time effort
There was a problem hiding this comment.
Nope because I switched to using dictionaries so we could have keyed campaign objects. You can't sort dictionaries in python.
Closed
|
Abandoning this due to some git fu failure on my part; recommitting changes and will re-issue pull request. |
|
I've replaced this with #53 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds templated photo description info to photo page on photo upload.