Skip to content
This repository has been archived by the owner on Jul 5, 2018. It is now read-only.

My uploads #62

Merged
merged 6 commits into from Jul 24, 2012
Merged

My uploads #62

merged 6 commits into from Jul 24, 2012

Conversation

yuvipanda
Copy link
Contributor

My uploads for completed uploads.

Uses WebSQL for storage. Can be easily extended to handle incomplete uploads too.

Notes:

  • Should probably create a 'Photo' prototype that should abstract away a lot of this code
  • UI polish needed on the completed upload photo page - perhaps should be the same as the screen you take people to after their photo is successfully uploaded

@jdlrobson
Copy link
Member

This pull request breaks the test suite. Please run assets/www/test.html and resolve.

@jdlrobson
Copy link
Member

  • We should show a message where there are no uploads - I'm seeing lots of blank screens
  • Should add link from upload success page to my uploads
  • Would it not be better to use the api to request uploads rather than caching uploads? If I use multiple devices it would be good to see uploads across devices rather than on a specific device

@jdlrobson
Copy link
Member

Also it seems strange that if I upload an image in Switzerland I would not expect it to appear in the my uploads tab when viewing monuments in Austria - we should either only show uploads that match with one of the monuments in the monuments list.

@yuvipanda
Copy link
Contributor Author

As per discussion on IRC, I think moving it out of a tab elsewhere should fix the last comment

@yuvipanda
Copy link
Contributor Author

Updated to not break tests. Also updated to not fail when user enters wrong password once. Shows no-uploads message when there are no uploads.

I'm refactoring a bunch of things into a Photo object in another commit, so linking to this from the 'upload-done' page would be easier. I think merging this in now would be a good idea :D

@jdlrobson jdlrobson merged commit c7614a9 into wikimedia:master Jul 24, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants