Improve error messages #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwilson
force-pushed
the
loading-T226760
branch
from
8499900
to
67b932d
Compare
mooeypoo
reviewed
Aug 22, 2019
mooeypoo
reviewed
Aug 22, 2019
samwilson
force-pushed
the
loading-T226760
branch
from
67b932d
to
4163681
Compare
Introduce three error states and show each of them according to the state of the response from WikiWho. Bug: T226760
samwilson
force-pushed
the
loading-T226760
branch
from
4163681
to
00bb814
Compare
samwilson
added
Ready for review
mooeypoo
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce three error states and show each of them according to
the state of the response from WikiWho.
https://phabricator.wikimedia.org/T226760
Bug: T226760