Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable based on whether VisualEditor is opened #64

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

mooeypoo
Copy link
Member

@mooeypoo mooeypoo commented Oct 9, 2019

When VisualEditor is opened, automatically dismiss WWT and disable
the link. When VisualEditor is closed, re-enable the WWT link.

Bug: https://phabricator.wikimedia.org/T231508

We will handle post-save in VisualEditor in a followup patch (related bug for followup: https://phabricator.wikimedia.org/T235015)

When VisualEditor is opened, automatically dismiss WWT and disable
the link. When VisualEditor is closed, re-enable the WWT link.

Bug: https://phabricator.wikimedia.org/T231508
@mooeypoo mooeypoo added the Ready for review This is ready for code review. label Oct 9, 2019
@MusikAnimal MusikAnimal merged commit ffb2f03 into master Oct 10, 2019
@MusikAnimal MusikAnimal deleted the ve-activation branch October 10, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review This is ready for code review.
Development

Successfully merging this pull request may close these issues.

2 participants