Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smooth transition from images in Article to Gallery #1645

Merged
merged 11 commits into from Oct 2, 2020
Merged

Smooth transition from images in Article to Gallery #1645

merged 11 commits into from Oct 2, 2020

Conversation

dbrant
Copy link
Member

@dbrant dbrant commented Sep 23, 2020

No description provided.

@dbrant
Stage toy transition between Page and Gallery.
7347b2d 
Change-Id: Ic8df2f508093eb9b22e7637efc6ac27bc34a8432
@dbrant
Not too bad.
a27bbfe 
Change-Id: I31b4bf09ea3434d1b7c2a82be91125a01f379bf3
@dbrant
Come on now.
30654cb 
Change-Id: I28ccff0505e5b573efbf1a1d7eb664a498bb27ba
@dbrant
Even better.
ca5aed0 
Change-Id: If87d4c5bf3816449e3615a7669bd4ffd8113ea40
@dbrant
Transition correctly from lead image.
08e669e 
Change-Id: I540423a4a6000af05c4792e2021b02b7cd67598c
@dbrant dbrant added the Experimental Experiments and prototypes label Sep 23, 2020
@dbrant
Keep private.
2a13363 
Change-Id: I28cb519dd244fcbd724f5219d3621cb016d534ac
@dbrant dbrant removed the Experimental Experiments and prototypes label Sep 30, 2020
cooltey
cooltey requested changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation is pretty smooth 👍

app/src/main/java/org/wikipedia/bridge/JavaScriptActionHandler.kt Outdated Show resolved Hide resolved
app/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java Show resolved Hide resolved
app/src/main/java/org/wikipedia/views/ViewUtil.java Show resolved Hide resolved
@dbrant
More refinement.
bc91085 
Change-Id: Ic8b8721a2a246a82bce7de6ae14770ecffc0ab08
cooltey
cooltey requested changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue can be optimized:
Click on an image in landscape (or a smaller image) -> while it is loading, swipe to the left/right images quickly -> you will see the transition image overlaps other images sometimes.

@dbrant
Copy link
Member Author

dbrant commented Oct 2, 2020

Found one issue can be optimized:
Click on an image in landscape (or a smaller image) -> while it is loading, swipe to the left/right images quickly -> you will see the transition image overlaps other images sometimes.

Do you have ideas for optimizing this?

@cooltey
Copy link
Collaborator

cooltey commented Oct 2, 2020

Found one issue can be optimized:
Click on an image in landscape (or a smaller image) -> while it is loading, swipe to the left/right images quickly -> you will see the transition image overlaps other images sometimes.

Do you have ideas for optimizing this?

Maybe disable the swipe before the image gets loaded?

@dbrant
Hide transition placeholder on swipe.
6414d29 
Change-Id: Ic578643836bf006eb6ef67d7a1de42139763849f
@dbrant
Copy link
Member Author

dbrant commented Oct 2, 2020

OK, here's the best I've got.

@cooltey cooltey merged commit e2bdea7 into master Oct 2, 2020
@dbrant dbrant deleted the articleGalleryTransition branch October 5, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooltey cooltey cooltey requested changes

@sharvaniharan sharvaniharan Awaiting requested review from sharvaniharan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@dbrant @cooltey @sharvaniharan