Fix edit comment when submitting short descriptions. #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm @dbrant but I couldn't still understand the root cause... looks like we were doing the same checks before |
dbrant
commented
Apr 13, 2021
| @@ -233,11 +233,7 @@ class DescriptionEditFragment : Fragment() { | |||
| val baseRevId = mwQueryResponse.query()!!.firstPage()!!.revisions()[0].revId | |||
| text = updateDescriptionInArticle(text, binding.fragmentDescriptionEditView.description!!) | |||
| ServiceFactory.get(wikiSite).postEditSubmit(pageTitle.prefixedText, "0", null, | |||
| when (action) { | |||
There was a problem hiding this comment.
@sharvaniharan If you look here, this block does not contain the check for if (invokeSource == InvokeSource.SUGGESTED_EDITS || invokeSource == InvokeSource.FEED), as the others do.
cooltey
added a commit
that referenced
this pull request
Apr 14, 2021
* imageRecs_design: Fix edit comment when submitting short descriptions. (#2305) Perform additional check for existence of descriptions. (#2306) Update short description capitalization guidance for English. (#2307) Bump versionCode (#2304) Fix display of numeric Developer Preferences. (#2303) Fix adding image caption from lead image. (#2302) Fix loading of Main Page via mobile-web call. (#2301) Solidify formatting of suggestion reasons. Instrument Image Recommendations on MEP (#2290) Image Recs: Success illustration (#2287) ImgRecs: tooltip textview lineHeight design tweak (#2297) set up illustration images for all themes (#2298) Fix string. Localisation updates from https://translatewiki.net.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edit comment of
suggestededit-add_1.0was being added incorrectly even when the edit came organically from the article, not just the Suggested Edits feature.https://phabricator.wikimedia.org/T279702