Add password is same as username check in app (T211639) #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvdvoort
requested review from
cooltey,
dbrant and
sharvaniharan
as code owners
dbrant
requested changes
Feb 24, 2022
app/src/main/java/org/wikipedia/createaccount/CreateAccountActivity.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/org/wikipedia/createaccount/CreateAccountActivityTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR adds a check to the CreateAccount and ResetPassword activities that will warn the user if the new password is the same as the username (T211639). This constraint is enforced by the Wikipedia site and it's useful to give users direct feedback on these constraints.
Yours sincerely, Sven.
P.S. I'm part of group of 4 students who will spend 10 weeks investigating the software architecture of wikipedia-android as part of the Software Architecture MSc course at TU Delft. We'll be writing several blog posts about our findings and make contributions to the project. If possible, it would be great to get in contact with core developers, both at the Wikimedia Foundation and volunteers, so please reach out! :)